Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add step to Github Action publish workflow to update version across example files #115

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

jessicamcinchak
Copy link
Member

I think this should work, but admittedly haven't tried queuing up a release to test it ! Ideas ofr testing locally, or we just test on next release?

See #114

If this doesn't work, we can alternatively try editing scripts/build-json-examples.ts - but this script isn't currently aware of the current schema version ($id), which differs from package.json version - so felt like the more complicated route.

@jessicamcinchak jessicamcinchak requested a review from a team February 13, 2024 08:54
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good solution to me!

@jessicamcinchak jessicamcinchak merged commit 1fb9bf2 into main Feb 13, 2024
3 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/gh-publish-correct-examples-version branch February 13, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants